optimize XDR serialization in serialize.c#234
Open
kevinushey wants to merge 1 commit intor-devel:mainfrom
Open
optimize XDR serialization in serialize.c#234kevinushey wants to merge 1 commit intor-devel:mainfrom
kevinushey wants to merge 1 commit intor-devel:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xdrmem_create/xdr_int/xdr_double/xdr_destroy) with an inlineR_swap32byte-swap for bulk integer, real, and complex vector serialization and deserialization, enabling compiler autovectorization of the inner loopsInIntegerVec,InRealVec,InComplexVec), read directly into the target SEXP buffer and byte-swap in place, eliminating the static intermediatebufOutStringto reduce per-characterOutBytescallssscanfinto a second buffer inInIntegerandInReal—InWordalready provides the parsed tokenstrlen(PRIMNAME(s))to avoid computing it twice inWriteItemTest plan
make checkpasses (serialization round-trips are exercised extensively by the test suite)serialize()/unserialize()on large integer, double, and complex vectors to confirm performance improvementWORDS_BIGENDIANpaths